-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh look of cluster pods admin tab #1583
Conversation
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
IMO having both the healthy and unhealthy counts in the right side but also having a healthy pods section and unhealthy pods section of the table feels a bit strange and redundant. |
First group is control plane pods (which can be a mix of healthy and unhealthy), the other is data plane pods, though I suppose only unhealthy ones so I should at least remove the healthy counter on that one. Are you suggesting combining the groups anyway and distinguishing them a different way? |
Ah I wasn't paying enough attention, yeah the count in dataplane pods is misleading then. I do still think that combining the tables and using some iconography to help indicate dataplane/controlplane might improve the flow here, what do you think? |
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Another nit: the before had chevrons to indicate that the rows could be expanded. Now there's no such indicators. can you add some right arrows? |
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Some more feedback on the design: how does this look if the status message is very long? And for the expanded view when you've clicked into a pod: do you think it'll look better with some padding at the top so that the pod name is a little lower? |
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Summary: Adds summary info, cleans up presentation.

Before...
After (with no pod selected)...

And with one selected...

Relevant Issues: #1174
Type of change: /kind cleanup
Test Plan: Go to
/admin/clusters
. Click a cluster. Go to the Pixie Pods tab.