Update Cypress to v12 #1641
Merged
Update Cypress to v12 #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update Cypress from 9.x to 12.x, and perform all relevant migrations.
Changes are the results of 10.0 migration, 11.0 migration, and 12.0 migration guides.
The reason for using
cypress.config.mjsinstead ofcypress.config.tsis that the latter is not working with Yarn 3 yet (1, 2, 3). If that changes, we can revisit.Notably, one of the larger changes is that test isolation is now on by default. This means the page is refreshed between each test rather than each suite, so some tests needed to be reconfigured to work with that paradigm.
Cypress' UI has gotten a major refresh as well, so I changed the commands to account for it.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Follow instructions in
src/ui/cypress/README.md. In particular, tryyarn run cypress:run:chrome. All of the tests should pass, totally headlessly.