fix strict null error in getChromiumChannelsFromEnv

pixiebrix · Aug 8, 2024 · 0efbd59 · 0efbd59
1 parent 215393b
commit 0efbd59
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/end-to-end-tests/fixtures/utils.ts b/end-to-end-tests/fixtures/utils.ts
@@ -18,6 +18,7 @@
 import { type BrowserContext, chromium } from "@playwright/test";
 import { CI, PWDEBUG, SLOWMO } from "../env";
 import path from "node:path";
+import { SupportedChannel } from "../../playwright.config";
 
 export const launchPersistentContextWithExtension = async (
   chromiumChannel: "chrome" | "msedge",
@@ -67,7 +68,7 @@ export const getExtensionId = async (context: BrowserContext) => {
 
 export const getAuthProfilePathFile = (
   profileName: string,
-  chromiumChannel: "chrome" | "msedge",
+  chromiumChannel: SupportedChannel,
 ) =>
   path.join(
     __dirname,

diff --git a/playwright.config.ts b/playwright.config.ts
@@ -15,9 +15,12 @@ export const SupportedChannels: Record<
 
 export type SupportedChannel = ValueOf<typeof SupportedChannels>;
 
-const channels: SupportedChannel[] = (() => {
+const getChromiumChannelsFromEnv = (): SupportedChannel[] => {
   if (!E2E_CHROMIUM_CHANNELS) {
-    return [SupportedChannels.CHROME, SupportedChannels.MSEDGE];
+    return [
+      SupportedChannels.CHROME,
+      SupportedChannels.MSEDGE,
+    ] as SupportedChannel[];
   }
 
   let parsedChannels: unknown;
@@ -49,7 +52,7 @@ const channels: SupportedChannel[] = (() => {
 
     return parsedChannel as SupportedChannel;
   });
-})();
+};
 
 /**
  * See https://playwright.dev/docs/test-configuration.
@@ -96,7 +99,7 @@ export default defineConfig<{ chromiumChannel: string }>({
     navigationTimeout: 10_000,
   },
   /* Configure projects for major browsers */
-  projects: channels.flatMap((chromiumChannel) => [
+  projects: getChromiumChannelsFromEnv().flatMap((chromiumChannel) => [
     {
       name: `${chromiumChannel}-setup`,
       use: