Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BrickModal - Split up into smaller components/files #3709

Closed
BLoe opened this issue Jun 14, 2022 · 1 comment · Fixed by #3810
Closed

Refactor BrickModal - Split up into smaller components/files #3709

BLoe opened this issue Jun 14, 2022 · 1 comment · Fixed by #3810
Assignees
@BLoe
Labels
developer experience
Milestone
1.7.2

Comments

@BLoe
Copy link
Contributor

BLoe commented Jun 14, 2022

BrickModal.tsx is getting pretty large, with several helper functions, many type defs, and everything wiring up the brick results grid view, all in the same file. We should think about how to split this file up to organize the code better and help with readability.
@BLoe BLoe mentioned this issue Jun 14, 2022
Merged
2 tasks
@twschiller twschiller added this to the 1.7.1 milestone Jun 17, 2022
@twschiller
Copy link
Contributor

@BLoe please add Jest tests and Storybook entries as part of this too. That will help guide how to split up the code

@BLoe BLoe mentioned this issue Jun 28, 2022
Merged
2 tasks
@twschiller twschiller modified the milestones: 1.7.1, 1.7.2 Jun 30, 2022
BLoe added a commit that referenced this issue Jul 12, 2022
@BLoe
#3709 Refactor brick modal code (#3810)
1aa42d7
@fregante fregante mentioned this issue Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BLoe BLoe

Labels
developer experience
Milestone
1.7.2
Development

Successfully merging a pull request may close this issue.

#3709 Refactor brick modal code pixiebrix/pixiebrix-extension
2 participants
@twschiller @BLoe