Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3613: fix response serialization for HTTP bricks #3667

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 12, 2022

What does this PR do?

Discussion

  • serializeError doesn't seem to handle Axios errors in the cause well at all on Chrome. (Was having problems replicating on node/in tests)

Checklist

  • Add tests
  • Designate a primary reviewer: @fregante

@twschiller twschiller requested a review from fregante June 12, 2022 19:46
@twschiller twschiller changed the title #3613: fix response serialization #3613: fix response serialization for HTTP bricks Jun 12, 2022
@twschiller twschiller added this to the 1.7.0 milestone Jun 12, 2022
@twschiller twschiller self-assigned this Jun 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3667 (0f18d22) into main (acefed0) will increase coverage by 0.02%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main    #3667      +/-   ##
==========================================
+ Coverage   45.59%   45.61%   +0.02%     
==========================================
  Files         816      816              
  Lines       24391    24407      +16     
  Branches     5138     5141       +3     
==========================================
+ Hits        11120    11134      +14     
- Misses      12354    12356       +2     
  Partials      917      917              
Impacted Files Coverage Δ
src/background/requests.ts 82.45% <95.00%> (+1.84%) ⬆️
src/pageEditor/hooks/useExtensionTrace.ts 79.31% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acefed0...0f18d22. Read the comment docs.

@twschiller twschiller merged commit 36e8f4f into main Jun 12, 2022
@twschiller twschiller deleted the feature/3613-serialize-response branch June 12, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants