Minor code changes extracted from #8151 #8176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8176 +/- ##
=======================================
Coverage 73.39% 73.39%
=======================================
Files 1313 1314 +1
Lines 40718 40722 +4
Branches 7571 7571
=======================================
+ Hits 29885 29888 +3
- Misses 10833 10834 +1 ☔ View full report in Codecov by Sentry. |
fregante
commented
Apr 6, 2024
| group: ["../*"], | ||
| message: | ||
| 'Use root-based imports (`import "@/something"`) instead of relative imports.', | ||
| }, |
There was a problem hiding this comment.
Moved in from pixiebrix/eslint-config-pixiebrix#249
| @@ -42,7 +42,7 @@ export function useLabelRenderer() { | |||
| href="#" | |||
| onClick={async (event) => { | |||
| await writeToClipboard({ | |||
| text: getPathFromArray(keyPath.reverse()), | |||
| text: getPathFromArray([...keyPath].reverse()), | |||
There was a problem hiding this comment.
Related future lint rule: https://togithub.com/sindresorhus/eslint-plugin-unicorn/issues/1514
| @@ -0,0 +1,110 @@ | |||
| /* | |||
| * Copyright (C) 2024 PixieBrix, Inc. | |||
There was a problem hiding this comment.
This file cannot be strict yet, 290 errors
grahamlangford
approved these changes
Apr 8, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
IsolatedComponent) #8151That PR is too big already, I removed some changes and sent them here:
.reverse()selectElementfromelementPicker, because that file is already big as it isChecklist