Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply mipmap fixed resolution accordingly to fixed and largest resolutions #96

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

f0nar
Copy link

@f0nar f0nar commented Oct 15, 2024

Hi

Sorry that I am coming without an issue but I think PR is pretty simple so we can start discussion here.

I need to generate fixed resolution other then 1. After migration to assetpack 1.2 (after 0.8) I found out that fix tag will not change asset resolution (size) but only naming.
I mean configs like

  resolutions: {
    low: 0.5,
    default: 1,
  },
  fixedResolution: 'low'

with fix tag on asset will copy asset as is without name or size changing.

I can reach needed result with config mentioned before but without fix tag applied but then redundant unchanged asset appear as output for default option.

You can reproduce it with this test by adding fix tag here and adding default: 1 option here
Note: currently this test is overlapped by this one. I dont know if it made on purpose but you need rename one of them to reproduce

Thanks =)

@f0nar f0nar changed the title fix: mipmap fixed resolution accordingly to fixed and largest resolutions fix: apply mipmap fixed resolution accordingly to fixed and largest resolutions Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant