Merge pull request #542 from pixijs/521-bug-v8-memoized-component-ren…

…ders-after-being-unmounted Destroy application on unmount
pixijs · Dec 26, 2024 · 3a19cbc · 3a19cbc
2 parents b6e870f + f3cc9e5
commit 3a19cbc
Show file tree

Hide file tree

Showing 21 changed files with 411 additions and 55 deletions.
diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml
@@ -29,7 +29,7 @@ runs:
       shell: bash
       run: npm ci --ignore-scripts --no-audit --no-fund
 
-    - name: Rebuild binaries
-      if: steps.node-modules-cache.outputs.cache-hit != 'true'
-      shell: bash
-      run: npm rebuild
+    # - name: Rebuild binaries
+    #   if: steps.node-modules-cache.outputs.cache-hit != 'true'
+    #   shell: bash
+    #   run: npm rebuild
diff --git a/.github/workflows/handle-release-branch-push.yml b/.github/workflows/handle-release-branch-push.yml
@@ -38,7 +38,7 @@ jobs:
         run: npm run ${{ matrix.script.command }}
 
   publish:
-    name: Publish
+    name: 'Publish: Release'
     needs:
       - verify
     if: contains(fromJson('["refs/heads/alpha", "refs/heads/beta", "refs/heads/main"]'), github.ref)
@@ -49,14 +49,14 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup Project
+      - name: Setup project
         uses: ./.github/actions/setup
 
       - name: Build Project
         run: npm run build
         shell: bash
 
-      - name: Semantic Release
+      - name: Semantic release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         id: release
@@ -71,3 +71,34 @@ jobs:
         if: ${{ steps.release.outputs.new_tag_version != '' }}
         run: npm publish ./dist/*.tgz --tag ${{ (github.head_ref || github.ref_name) == 'main' && 'latest' || github.head_ref || github.ref_name }}
         shell: bash
+
+  # dev-publish:
+  #   name: 'Publish: Dev'
+  #   needs:
+  #     - verify
+  #   if: contains(fromJson('["refs/heads/alpha", "refs/heads/beta", "refs/heads/main"]'), github.ref) == 'false'
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/checkout@v4
+  #       with:
+  #         fetch-depth: 0
+
+  #     - name: Setup project
+  #       uses: ./.github/actions/setup
+
+  #     - name: Build project
+  #       run: npm run build
+  #       shell: bash
+
+  #     - name: Get current version
+  #       run: echo "PACKAGE_VERSION=$(npm pkg get version | tr -d '"')" >> $GITHUB_ENV
+
+  #     - name: Setup dev version
+  #       run: echo "BRANCH_VERSION=$PACKAGE_VERSION-$BRANCH_NAME.${GITHUB_SHA::7}" >> $GITHUB_ENV
+
+  #     - name: Bump version
+  #       run: npm version $BRANCH_VERSION --no-git-tag-version --force
+
+  #     - name: Publish a dev release
+  #       run: npm publish --tag dev