Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested primary key not supported bug #2

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix nested primary key not supported bug #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd3d52a
Fix nested primary key not supported bug
sukantaroy01 Jul 22, 2024
37ebcdb
Update code to pass lint cheks
sukantaroy01 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airbyte/_future_cdk/sql_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,10 @@ def _get_primary_keys(
if not pks:
return []

joined_pks = [".".join(pk) for pk in pks]
# Normalize the primary keys to match the normalized column names
normalized_pks = [[self.normalizer.normalize(c) for c in pk] for pk in pks]

joined_pks = [".".join(pk) for pk in normalized_pks]
for pk in joined_pks:
if "." in pk:
msg = f"Nested primary keys are not yet supported. Found: {pk}"
Expand Down