New imageicon interface #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvvzr
reviewed
Sep 20, 2023
| {% elif asset.type == "symbol" %} | ||
| {{accessModifier}} static let {{asset.name|swiftIdentifier:"pretty"|lowerFirstWord|escapeReservedKeywords}} = {{symbolType}}(name: "{{asset.value}}") | ||
| {% elif asset.items and ( forceNamespaces == "true" or asset.isNamespaced == "true" ) %} | ||
| {{accessModifier}} enum {{asset.name|swiftIdentifier:"pretty"|escapeReservedKeywords}} { | ||
| {% filter indent:2," ",true %}{% call casesBlock asset.items %}{% endfilter %} | ||
| {{accessModifier}} enum {{asset.name|swiftIdentifier:"pretty"|escapeReservedKeywords}} : CaseIterable { |
There was a problem hiding this comment.
ライブラリを使う側の人にとってはCaseIterableは不要だと思うので、ここでは削っていただけると 🙏
CaseIterableを付けたいと思ったのはSample側の話でした
There was a problem hiding this comment.
extensionでCaseIterableを書く場合、allCasesを自分で実装する必要があったため、やはりこの方針でいくのが良いとなった
| @@ -148,7 +163,7 @@ | |||
| {{accessModifier}} enum {{enumName}} { | |||
| {% if catalogs.count > 1 or param.forceFileNameEnum %} | |||
| {% for catalog in catalogs %} | |||
| {{accessModifier}} enum {{catalog.name|swiftIdentifier:"pretty"|escapeReservedKeywords}} { | |||
| {{accessModifier}} enum {{catalog.name|swiftIdentifier:"pretty"|escapeReservedKeywords}} : CaseIterable { | |||
kvvzr
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解決したいこと
Image(charcoalIcon: .add)のように画像を設定できるようにする
やったこと
複数の AssetGroup をフラット化しています
動作確認環境
iOS 13 - iOS 16