Yarn の PnP モードを試す #240
Closed
Yarn の PnP モードを試す #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
もしかして pnp のブランチと非 pnp のブランチで bundle size 比較を走らすのって厳しいかな（できるのか…？） |
fsubal
commented
Feb 27, 2023
| clean-script: 'clean' | ||
|
|
||
| # compressed-size-action は PnP だとうまく動かない | ||
| clean-script: 'disable-pnp-before-build' |
|
pnpm 優勢のためいったん close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
動作確認環境
CI が通ること、手元でエディタが普通に動くこと、Storybook が起動すること
懸念
pnp はエディタの特殊対応が必要で、たとえば VSCode で動かすには yarn の vscode sdk が必要になる。
https://yarnpkg.com/getting-started/editor-sdks
これは事実上、charcoal にコントリビューションする際の環境は事実上 VSCode しかサポートしなくなることを意味するかも
（他のエディタ向け SDK を追加してもよいが、ちゃんと動くかを我々が保証できないと思われる）
チェックリスト
不要なチェック項目は消して構いません