feat(@pixiv/eslint-config): update rules

pixiv · Oct 25, 2024 · b2597b4 · b2597b4
1 parent a8c9f0d
commit b2597b4
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 6 deletions.
diff --git a/packages/eslint-config/src/__snapshots__/next.rules.json b/packages/eslint-config/src/__snapshots__/next.rules.json
@@ -4,7 +4,12 @@
   "no-fallthrough": "error",
   "no-constant-condition": "error",
   "object-shorthand": "error",
-  "@typescript-eslint/no-unused-vars": "error",
+  "@typescript-eslint/no-unused-vars": [
+    "error",
+    {
+      "argsIgnorePattern": "^_"
+    }
+  ],
   "@typescript-eslint/consistent-type-imports": [
     "error",
     {
@@ -38,9 +43,12 @@
       ]
     }
   ],
-  "react/prop-types": "warn",
   "react/require-render-return": 2,
   "react/self-closing-comp": "error",
+  "react/jsx-boolean-value": [
+    "error",
+    "never"
+  ],
   "react-hooks/rules-of-hooks": "error",
   "react-hooks/exhaustive-deps": "error",
   "react-compiler/react-compiler": "warn",

diff --git a/packages/eslint-config/src/__snapshots__/recommended.rules.json b/packages/eslint-config/src/__snapshots__/recommended.rules.json
@@ -4,7 +4,12 @@
   "no-fallthrough": "error",
   "no-constant-condition": "error",
   "object-shorthand": "error",
-  "@typescript-eslint/no-unused-vars": "error",
+  "@typescript-eslint/no-unused-vars": [
+    "error",
+    {
+      "argsIgnorePattern": "^_"
+    }
+  ],
   "@typescript-eslint/consistent-type-imports": [
     "error",
     {
@@ -38,9 +43,12 @@
       ]
     }
   ],
-  "react/prop-types": "warn",
   "react/require-render-return": 2,
   "react/self-closing-comp": "error",
+  "react/jsx-boolean-value": [
+    "error",
+    "never"
+  ],
   "react-hooks/rules-of-hooks": "error",
   "react-hooks/exhaustive-deps": "error",
   "react-compiler/react-compiler": "warn",

diff --git a/packages/eslint-config/src/config.ts b/packages/eslint-config/src/config.ts
@@ -85,7 +85,12 @@ export const typescript = () => [
 
     rules: {
       'no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-vars': 'error',
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+        },
+      ],
       "@typescript-eslint/consistent-type-imports": [
         "error",
         {
@@ -122,7 +127,8 @@ export const react = () => [
       "react/self-closing-comp": "error",
       "react/react-in-jsx-scope": "off",
       "react/jsx-no-target-blank": "off",
-      "react/prop-types": "warn",
+      'react/prop-types': 'off',
+      "react/jsx-boolean-value": ["error", "never"],
       "react/display-name": "warn",
       "react/no-unknown-property": [
         "error",