fix: Fix parsing animation from VRMA with scales

setFromRotationMatrix don't work with world matrices with scales replaced with decompose
pixiv · Feb 14, 2024 · 155382e · 155382e
1 parent d8b3127
commit 155382e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/three-vrm-animation/src/VRMAnimationLoaderPlugin.ts b/packages/three-vrm-animation/src/VRMAnimationLoaderPlugin.ts
@@ -198,8 +198,10 @@ export class VRMAnimationLoaderPlugin implements GLTFLoaderPlugin {
           const worldMatrix = worldMatrixMap.get(boneName)!;
           const parentWorldMatrix = worldMatrixMap.get(parentBoneName)!;
 
-          _quatA.setFromRotationMatrix(worldMatrix).normalize().invert();
-          _quatB.setFromRotationMatrix(parentWorldMatrix).normalize();
+          worldMatrix.decompose(_v3A, _quatA, _v3A);
+          _quatA.invert();
+
+          parentWorldMatrix.decompose(_v3A, _quatB, _v3A);
 
           const trackValues = arrayChunk(origTrack.values, 4).flatMap((q) =>
             _quatC.fromArray(q).premultiply(_quatB).multiply(_quatA).toArray(),