Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump three r144 #1060

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Bump three r144 #1060

merged 2 commits into from
Sep 26, 2022

Conversation

ke456-png
Copy link
Contributor

@ke456-png ke456-png commented Sep 26, 2022

Description

three.js のバージョンを0.140.2から0.144.0へ更新します

three.jsのマイグレーションガイド
https://github.com/mrdoob/three.js/wiki/Migration-Guide

@ke456-png
Copy link
Contributor Author

ke456-png commented Sep 26, 2022

コード検索もかけたが、該当箇所はなさそう。
https://github.com/mrdoob/three.js/wiki/Migration-Guide

@ke456-png
Copy link
Contributor Author

releasesも確認する
https://github.com/mrdoob/three.js/releases

@ke456-png
Copy link
Contributor Author

少し気になった変更
mrdoob/three.js#24284

とは言え、PRにもある通りデフォルトはtrueなので影響は無さそうです

@0b5vr
Copy link
Contributor

0b5vr commented Sep 26, 2022

releasesを見た感じ、刺さりそうなdiffはなさそうですね。
examplesも問題なさそうです。

@ke456-png ke456-png self-assigned this Sep 26, 2022
@ke456-png ke456-png merged commit 930164e into dev Sep 26, 2022
@ke456-png ke456-png deleted the bump-three-r144 branch September 26, 2022 10:09
@0b5vr 0b5vr added this to the next milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants