Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert exports to unminified build #1416

Merged
merged 1 commit into from
May 29, 2024

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented May 29, 2024

Revert exports to unminified build.
By exporting minified build entries it may reduce bundle size and build speed for certain client setup, but it will drop sourcemap and break current dev flow.
For now .min.{js,cjs} files can only be consumed via CDN.
IMO, it's more common to avoid mutiple dev server but doing that is out-of-scope for v3.

@yue4u yue4u changed the base branch from dev to dev-v3 May 29, 2024 06:01
@0b5vr 0b5vr self-requested a review May 29, 2024 06:03
@0b5vr 0b5vr added this to the v3 milestone May 29, 2024
@yue4u yue4u merged commit 7e78c39 into dev-v3 May 29, 2024
6 checks passed
@yue4u yue4u deleted the fix/revert-exports-to-unminified-build branch May 29, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants