Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote extended collider specVersion from 1.0-draft to 1.0 #1461

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: promote extended collider specVersion from 1.0-draft to 1.0 #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/three-vrm-springbone/examples/models/inside-collider.gltf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
},
"extensions": {
"VRMC_springBone_extended_collider": {
"specVersion": "1.0-draft",
"specVersion": "1.0",
"shape": {
"sphere": {
"radius": 1.25,
Expand Down
2 changes: 1 addition & 1 deletion packages/three-vrm-springbone/examples/models/plane-collider.gltf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@
},
"extensions": {
"VRMC_springBone_extended_collider": {
"specVersion": "1.0-draft",
"specVersion": "1.0",
"shape": {
"plane": {
"normal": [
Expand Down
2 changes: 1 addition & 1 deletion packages/three-vrm-springbone/src/VRMSpringBoneLoaderPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const POSSIBLE_SPEC_VERSIONS = new Set(['1.0', '1.0-beta']);
/**
* Possible spec versions of `VRMC_springBone_extended_collider` it recognizes.
*/
const POSSIBLE_SPEC_VERSIONS_EXTENDED_COLLIDERS = new Set(['1.0-draft']);
const POSSIBLE_SPEC_VERSIONS_EXTENDED_COLLIDERS = new Set(['1.0']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't expect to see much of 1.0-draft models, we will drop support 1.0-draft at this time.


export class VRMSpringBoneLoaderPlugin implements GLTFLoaderPlugin {
public static readonly EXTENSION_NAME = 'VRMC_springBone';
Expand Down
2 changes: 1 addition & 1 deletion ...ges/types-vrmc-springbone-extended-collider-1.0/types/VRMCSpringBoneExtendedCollider.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface VRMCSpringBoneExtendedCollider {
/**
* Specification version of VRMC_springBone_extended_collider.
*/
specVersion: '1.0-draft';
specVersion: '1.0';

/**
* The shape of the collider.
Expand Down
Loading