Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Fix rim lighting #851

Merged
merged 3 commits into from
Nov 4, 2021
Merged

[1.0] Fix rim lighting #851

merged 3 commits into from
Nov 4, 2021

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Nov 2, 2021

  • Beginning from Three.js r133, it utilizes SRGB8_ALPHA8 textures instead of inline conversions. This PR supports the behavior.
  • MatCap was not working as "MatCap", this PR should fix the behavior.

@0b5vr 0b5vr added bug Something isn't working VRM 1.0 labels Nov 2, 2021
@0b5vr 0b5vr added this to the VRM 1.0 milestone Nov 2, 2021
@0b5vr 0b5vr self-assigned this Nov 2, 2021
@0b5vr
Copy link
Contributor Author

0b5vr commented Nov 4, 2021

Confirmed that it's working between r126-r133, merging

@0b5vr 0b5vr merged commit 56d3dcb into 1.0 Nov 4, 2021
@0b5vr 0b5vr deleted the fix-rim-lighting branch November 4, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0b5vr 0b5vr

Labels
bug Something isn't working VRM 1.0
Projects
None yet
Milestone
VRM 1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@0b5vr