Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer has_ as prefix of predicate methods #11

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Conversation

necojackarc
Copy link
Contributor

Ruby's naming convention discourages developers from putting has_ as a prefix to predicate methods.
For readability, however, I agree with the author of rubocop/rubocop#3428.

@necojackarc necojackarc self-assigned this Jun 9, 2017
@necojackarc necojackarc requested a review from yasaichi June 9, 2017 08:13
@yasaichi
Copy link
Contributor

yasaichi commented Jun 9, 2017

LGTM

@yasaichi yasaichi merged commit cf10720 into master Jun 9, 2017
@yasaichi yasaichi deleted the prefer-has-prefix branch January 9, 2020 15:30
@yasaichi yasaichi restored the prefer-has-prefix branch January 9, 2020 15:30
@yasaichi yasaichi deleted the prefer-has-prefix branch January 9, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants