Skip to content

Commit

Permalink
Add missing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pjanotti committed Apr 11, 2021
1 parent 6d45d84 commit 5c91d09
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions experimental/configsource/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,5 @@ type Factory interface {
CreateConfigSource(ctx context.Context, params CreateParams, cfg ConfigSettings) (ConfigSource, error)
}

// Factories is a map from types of ConfigSource and the respective Factory for the type.
type Factories map[config.Type]Factory
2 changes: 2 additions & 0 deletions experimental/configsource/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import (
"go.opentelemetry.io/collector/config"
)

// ConfigSettings is an interface that must be supported by all configuration objects
// of ConfigSource implementations.
type ConfigSettings interface {
config.NamedEntity
}
Expand Down
1 change: 1 addition & 0 deletions experimental/configsource/vaultconfigsource/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"go.opentelemetry.io/collector/experimental/configsource"
)

// Config holds the configuration settings for Vault ConfigSource objects.
type Config struct {
*configsource.Settings
// Endpoint is the address of the Vault server, typically it is set via the
Expand Down
1 change: 1 addition & 0 deletions experimental/configsource/vaultconfigsource/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func (v *vaultFactory) CreateConfigSource(_ context.Context, params configsource
return newConfigSource(params.Logger, vaultCfg)
}

// NewFactory creates a factory for Vault ConfigSource objects.
func NewFactory() configsource.Factory {
return &vaultFactory{}
}

0 comments on commit 5c91d09

Please sign in to comment.