ErrorFormat and TODO when double-uninstalling mods.

For KSP-CKAN#125.
pjf · Oct 23, 2014 · 4430e00 · 4430e00
1 parent fdf649f
commit 4430e00
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/CKAN/CKAN/ModuleInstaller.cs b/CKAN/CKAN/ModuleInstaller.cs
@@ -727,7 +727,10 @@ public void Uninstall(string modName, bool uninstallDependencies)
         {
             if (!registry_manager.registry.IsInstalled(modName))
             {
-                log.WarnFormat("Trying to uninstall {0} but it's not installed", modName);
+                // TODO: This could indicates a logic error somewhere;
+                // change to a kraken, the calling code can always catch it
+                // if it expects that it may try to uninstall a module twice.
+                log.ErrorFormat("Trying to uninstall {0} but it's not installed", modName);
                 return;
             }
 
@@ -791,7 +794,7 @@ public void Uninstall(string modName, bool uninstallDependencies)
                 }
             }
 
-            // And we're done! :)
+            return;
         }
     }
 }