Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 3.0.x and Pekko updates #6

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Conversation

sentenza
Copy link

In order to use op-rabbit-play-json with Play v3.0.x this library should target Play 3, which is the only version supporting Pekko.

@pjfanning
Copy link
Owner

Hi @sentenza , thanks for the PR - I'll look into merging this if the tests pass and hopefully will get a release done within a few hours - all going well.

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
project/build.properties Outdated Show resolved Hide resolved
@pjfanning pjfanning merged commit e54866c into pjfanning:main Dec 22, 2023
1 check passed
@sentenza sentenza deleted the upgrade-play3 branch December 22, 2023 15:29
@pjfanning
Copy link
Owner

seems fine - I'll set up a v4.0.0 release - probably best to treat it is a major change due to the group id change on play libs

@sentenza
Copy link
Author

@pjfanning thank you. Yes, this is not retro-compatible with Play 2.9 and in general Pekko can only be used with Play 3, so the previous version of this library cannot really be used either with Play 2.9 or Play 3.

I believe that those two issues are also related to wrong transitive dependencies imported via op-rabbit:3.0.0: lloydmeta/enumeratum#388 and playframework/play-grpc#499.

@pjfanning
Copy link
Owner

op-rabbit 4.0.0-SNAPSHOT is published with these changes

@sentenza
Copy link
Author

@pjfanning I've already tested v4.0.0 and it's working as expected, solving all the cross-dependency issues. Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants