Fix windows subsystem #8
Conversation
|
By the way, usually you expect nothing to be printed to your stdout when calling commands on an API like this one[, but error]. The reason I am removing it is because Windows does print something. |
|
I agree it should be constrained to files ending in _windows.go and makes little to no sense to have them on a file ending in linux.go, but we should blame Windows subsystem on it as there seems to be no standard way to detect it (and the program identifies it as Linux) ¯_(ツ)/¯ Probably there's not much to do regarding this. |
|
A little necromancy here, but as WSL usage is growing, would be nice to solve it somehow. Can confirm the fix does need to be in the |
Windows Subsystem for Linux failed to open a browser due to lack of support for xdg-open. This commit reuses a solution from pkg/browser#8 which detects a WSL environment and uses cmd.exe to open the URL instead.
With the current implementation of terraform login, Windows Subsystem for Linux fails to open a browser due to lack of support for xdg-open. This commit reuses a fix from pkg/browser#8 which detects a WSL environment and uses cmd.exe to open the URL instead.
With the current implementation of terraform login, Windows Subsystem for Linux fails to open a browser due to lack of support for xdg-open. This commit reuses a fix from pkg/browser#8 which detects a WSL environment and uses cmd.exe to open the URL instead.
|
This should use |
|
Perhaps this?
I don't maintain anything supposed to run on Windows anymore, so maybe you or someone else could continue from here? |
|
Hey @davecheney , I'm looking at creating a new PR to do this properly, how do you envision doing this without touching browser_linux ? Since WSL uses GOOS linux |
|
Tidying up, Closing this as very old, please reopen if still relevant. |
I think this is an acceptable solution for this (though awkward). I can't think of anything better.
It might be related to the error described on #6.
Please see:
https://blogs.msdn.microsoft.com/commandline/2016/10/19/interop-between-windows-and-bash/
microsoft/WSL#423