normalise permission denied error as file not found error

pkg · Dec 8, 2020 · f5fd2fb · f5fd2fb
1 parent 7230c61
commit f5fd2fb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/client.go b/client.go
@@ -1363,6 +1363,8 @@ func normaliseError(err error) error {
 			return io.EOF
 		case sshFxNoSuchFile:
 			return os.ErrNotExist
+		case sshFxPermissionDenied:
+			return os.ErrPermission
 		case sshFxOk:
 			return nil
 		default:

diff --git a/client_integration_test.go b/client_integration_test.go
@@ -453,16 +453,13 @@ func TestClientCreateFailed(t *testing.T) {
 	defer sftp.Close()
 
 	f, err := ioutil.TempFile("", "sftptest-createfailed")
-	if err != nil {
-		t.Fatal(err)
-	}
+	require.NoError(t, err)
+
 	defer f.Close()
 	defer os.Remove(f.Name())
 
 	f2, err := sftp.Create(f.Name())
-	if err1, ok := err.(*StatusError); !ok || err1.Code != sshFxPermissionDenied {
-		t.Fatalf("Create: want: %v, got %#v", sshFxPermissionDenied, err)
-	}
+	require.True(t, os.IsPermission(err))
 	if err == nil {
 		f2.Close()
 	}