-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ioutil.ReadAll never finishes downloading a file with disabled concurency #489
Comments
OOooooof… yeah, this looks like it was copied from I’ll be happy to accept a PR. 👍 |
glebteterin
added a commit
to glebteterin/sftp
that referenced
this issue
Jan 19, 2022
puellanivis
added a commit
that referenced
this issue
Jan 19, 2022
Fix missing io.EOF when concurency is disabled #489
Fixed in #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm connecting to a server with
sftp.UseConcurrentReads(false)
, then open a file with Client.Open and read it to memory with ioutil.ReadAll. Due to thereadAtSequential
function (client.go) suppressing io.EOF error, the ioutil.ReadAll can't know when the file is fully read and won't finish.I'm not sure I understand the reasoning for File.Read() doesn't return io.EOF, it seems like a bug introduced during refactoring. If so, would you accept a PR that fixes it?
The text was updated successfully, but these errors were encountered: