Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ssh dep to fix vuln #340

Merged
merged 1 commit into from
Feb 27, 2020
Merged

bump ssh dep to fix vuln #340

merged 1 commit into from
Feb 27, 2020

Conversation

twmb
Copy link
Contributor

@twmb twmb commented Feb 25, 2020

https://groups.google.com/forum/#!topic/golang-dev/bhd3Qn9_Q1k

Via go get -u, so includes one more day of commits rather than the exact commit referenced in the link.

@puellanivis
Copy link
Collaborator

The vulnerability seems to be unclear about when the issue was introduced, and just says the 20200220 commit version is vulnerable, and that is not the one we are using.

I’m not saying that we should not update the version, but it would be nice if security vulnerabilities always explained what versions are impacted.

@twmb
Copy link
Contributor Author

twmb commented Feb 26, 2020

This likely affects most backwards versions. Here's the fix commit.

I've pinned ssh where I need to an appropriate version, so I don't mind if this bump is not merged, but I recommend it be.

@puellanivis
Copy link
Collaborator

Yeah, go.mod intends that transitive dependencies should be updated regardless of what the middle-package says it requires. But this is still a good merge, considering the bug.

Best to not “recommend” a bad version.

@puellanivis puellanivis merged commit 21ab0e5 into pkg:master Feb 27, 2020
@eikenb
Copy link
Member

eikenb commented Feb 28, 2020

Thanks so much @twmb and @puellanivis for fixing this! I was AFK all week at a work function and didn't even see this until now. Really, I appreciate it so much.

@eikenb eikenb added the bug label Feb 28, 2020
@eikenb eikenb added this to the v1.11.1 milestone Mar 7, 2020
@eikenb eikenb modified the milestones: v1.11.1, v1.12.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants