cleanPath: use path.IsAbs after converting ToSlash

[drakkan]

we need a POSIX path, filepath.IsAbs could give unexpected results on Windows.

I don't have any specific test case for this anyway I think that filepath.IsAbs could consider an absolute path things like C:/path on Windows

[puellanivis]

Seems likely, but it’s not immediately clear that this is the more correct behavior. I will take a look sometime (probably next week) and make sure it’s solid before merging.

[drakkan]

Hi, sorry for the delay, I just found some time to test on Windows and I added a test case.

As expected without the patch it fails on Windows:

 request-server_test.go:426:
             Error Trace:    request-server_test.go:426
             Error:          Not equal:
                             expected: "/C:/a"
                             actual  : "C:/a"

                             Diff:
                             --- Expected
                             +++ Actual
                             @@ -1 +1 @@
                             -/C:/a
                             +C:/a
             Test:           TestCleanPath

[puellanivis]

Looks legit. The function even says, “a clean POSIX path”.