Remove tautology statement

[wn]

Remove tautology statement. Consider the for-loop above, there is no way to break out of the loop unless err != nil.

[puellanivis]

Looks pretty legit. At the very least, the value of err cannot change in the loop, and as a loop invariant should be tested outside of the loop entirely. But then, as noted, the only way out of the loop above, is if err != nil.

[wn]

Could i get an LGTM?

[puellanivis]

I just spotted a bug, not in your code, but in the code above it. I’ll fix that, and then push the two together.

[puellanivis]

Closing with deference to #363 which fixes a bunch of bugs spotted while reviewing this PR. (They’re not bugs from this PR.)

[eikenb]

Thanks for handling this @puellanivis!