Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request-server: don't return EOF if there is an unexpected error #392

Merged
merged 3 commits into from
Nov 18, 2020
Merged

request-server: don't return EOF if there is an unexpected error #392

merged 3 commits into from
Nov 18, 2020

Commits on Nov 16, 2020

  1. request-server: don't return EOF if there is an unexpected error 

    io.EOF means no error so convert to ErrUnexpectedEOF if we detect
a transfer error
    @drakkan
    drakkan committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    6af3f0a View commit details
    Browse the repository at this point in the history

  2. request-server: add test cases for server errors

    @drakkan
    drakkan committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    8637833 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. request-server test: set size for the error channel to 1 

    This way even if we do not read from this channel, there is not a
blocked goroutine left hanging
    @drakkan
    drakkan committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    75eca30 View commit details
    Browse the repository at this point in the history