Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request-server: add StatVFS support #406

Merged
merged 2 commits into from
Feb 10, 2021
Merged

request-server: add StatVFS support #406

merged 2 commits into from
Feb 10, 2021

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented Feb 10, 2021

Besides the included test case, I also did a basic test using the request server example and the sftp CLI, here is the output:

sftp -P 2022 testuser@127.0.0.1
testuser@127.0.0.1's password: 
Connected to 127.0.0.1.
sftp> df
        Size         Used        Avail       (root)    %Capacity
   490945448    431669628     54261036     59275820          87%

thank you

added a test case for the request server to check os.IsNotExist error
@@ -55,14 +55,22 @@ type FileCmder interface {
Filecmd(*Request) error
}

// PosixRenameFileCmder is a FileCmder that implements the Lstat method.
// PosixRenameFileCmder is a FileCmder that implements the PosixRename method.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️

@drakkan
Copy link
Collaborator Author

drakkan commented Feb 10, 2021

Thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants