Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to disable concurrent reads #408

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Conversation

drakkan
Copy link
Collaborator

@drakkan drakkan commented Feb 23, 2021

Fixs #345

client.go Show resolved Hide resolved
@corey-fuller
Copy link

corey-fuller commented Mar 4, 2021

@puellanivis Is there a plan for this to be merged soon? My team has some issues with downloading files from a new SFTP server that this change may resolve.

@drakkan
Copy link
Collaborator Author

drakkan commented Mar 4, 2021

@puellanivis Is there a plan for this to be merged soon? My team has some issues with downloading files from a new SFTP server that this change may resolve.

Hi, you could test this patch and tells us if it works, we don't have a read once SFTP server to test it ourself, thank you

@corey-fuller
Copy link

corey-fuller commented Mar 4, 2021 via email

@drakkan
Copy link
Collaborator Author

drakkan commented Mar 4, 2021

It actually does work for our case. Thanks for checking with us. We haven’t tested every case, and don’t know a lot about how this works behind the scenes, but for our use case, it is working. We had an issue that this fix resolves with connecting to an IBM Sterling File Gateway SFTP server. Thanks, Corey

On Thu, Mar 4, 2021 at 15:18 Nicola Murino @.***> wrote: @puellanivis https://github.com/puellanivis Is there a plan for this to be merged soon? My team has some issues with downloading files from a new SFTP server that this change may resolve. Hi, you could test this patch and tells us if it works, we don't have a read once SFTP server to test it ourself, thank you — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#408 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATC3KHDYOOK4TMF34EIRTHLTB72KRANCNFSM4YC647RA .

Thank you for confirming, I'll do the change requested by @puellanivis and then I think this patch could be merged

... and the requested buffer is bigger than maxPacket
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@corey-fuller
Copy link

Thank you both so much for getting this out there so quickly @puellanivis & @drakkan.
This is super helpful for our team. :)

@drakkan drakkan deleted the 345 branch July 15, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants