bugfix: int64 math overflows possible on 32-bit architectures #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
commented
Apr 22, 2021
puellanivis
commented
Apr 22, 2021
Comment on lines
+1655
to
+1657
| if remain < 0 { | ||
| remain = math.MaxInt64 | ||
| } |
There was a problem hiding this comment.
This was added from discussion in #426 where we want to default to maximum concurrency when we have a Size reported as less than 0.
|
Thank you |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating #433 I tracked it down to a situation where an overflow in 32-bit architectures can result in a calculation of
concurrency = 0. With zero concurrency… thewg.Wait()returns immediately and no work is done.The solution is to check if concurrency is less than one, and if it is, then use max concurrency, as we overflowed an int32, so it should use max concurrency.