Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export a ReadFromWithConcurrency function that permits ensuring concurrency usage. #439

Merged
merged 1 commit into from
May 22, 2021

Conversation

puellanivis
Copy link
Collaborator

Surfaces the readFromConcurrent into a ReadFromWithConcurrency alternative that allows the caller to be able to ensure that concurrency will be used.

@puellanivis
Copy link
Collaborator Author

🤦‍♀️ forgot to run a full set of tests prior to pushing the PR. 😆 No one is perfect.

@puellanivis
Copy link
Collaborator Author

sftp$ GOARCH=386 make integration

This one fails, but it only fails because there is no UID/GID matching outside of CGO_ENABLED=1, this is known from the client refactor to use filexfer and should be resolved after that.

@drakkan
Copy link
Collaborator

drakkan commented May 22, 2021

LGTM, thank you

@drakkan drakkan merged commit 5b98d05 into master May 22, 2021
@drakkan drakkan mentioned this pull request Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants