Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for obtaining window size options. #46

Closed
wants to merge 1 commit into from

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Jun 25, 2019

This builds upon PR #45, but it could also be rebased ahead if desired. This adds a nice way for us to get the Window size, which is very useful for applications like tcell.

There is some gofmt noise, as my editor automatically runs go fmt to clean things up. If that is bothersome, let me know and I'll strip that out.

@tj
Copy link

tj commented Oct 1, 2019

👍 would be great to have a consolidated package for the lower level functionality, seems that most people inline this stuff in larger projects but with all the compatibility issues that's a huge pain

@gdamore
Copy link
Contributor Author

gdamore commented May 24, 2020

It is indeed a huge pain. It looks like the maintainer of this package is not interested in PRs submitted from other folks -- which is his right certainly. If anyone else is watching this space and thinking of contributing here, it is probably something to be aware of.

@giulianopz
Copy link

It is indeed a huge pain. It looks like the maintainer of this package is not interested in PRs submitted from other folks -- which is his right certainly. If anyone else is watching this space and thinking of contributing here, it is probably something to be aware of.

This repo should be archived since now Go has official support to interact with terminals: https://github.com/golang/term.

@gdamore gdamore closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants