Skip to content

Commit

Permalink
MissingRemoteId: Simplify _gitlab_match to avoid false positives
Browse files Browse the repository at this point in the history
https://gitlab.com/api/v4/projects/37881342/packages/generic/spicetify-cli/2.27.1/spicetify-cli-2.27.1-deps.tar.xz

Before: api/v4/projects/37881342/packages/generic/spicetify-cli/2.27.1/spicetify-cli-2.27.1-deps.tar.xz
After: api/v4

Signed-off-by: Alfred Wingate <parona@protonmail.com>
  • Loading branch information
parona-source committed Nov 26, 2023
1 parent d837ae2 commit 6d86388
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/pkgcheck/checks/metadata_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,8 @@ class MissingRemoteIdCheck(Check):
_source = sources.PackageRepoSource
known_results = frozenset([MissingRemoteId])

_gitlab_match = r"(?P<value>(\w[^/]*/)*\w[^/]*/\w[^/]*)"
# https://docs.gitlab.com/ee/user/reserved_names.html#limitations-on-project-and-group-names
_gitlab_match = r"(?P<value>\w[^/]*\w/\w[^/]*\w)"

remotes_map = (
("bitbucket", r"https://bitbucket.org/(?P<value>[^/]+/[^/]+)"),
Expand Down

0 comments on commit 6d86388

Please sign in to comment.