Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EbuildReservedCheck: check for semi-reserved names #552

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

arthurzam
Copy link
Member

Gentoo results
  app-editors/padre
    EbuildSemiReservedName: version 1.0.0-r2: line 19: uses semi-reserved variable name "TDEPEND", likely to clash with future EAPIs
  
  app-text/texlive-core
    EbuildSemiReservedName: version 2021-r2: line 133: uses semi-reserved variable name "B", likely to clash with future EAPIs
    EbuildSemiReservedName: version 2021-r3: line 134: uses semi-reserved variable name "B", likely to clash with future EAPIs
    EbuildSemiReservedName: version 2021-r6: line 134: uses semi-reserved variable name "B", likely to clash with future EAPIs
  
  dev-lang/mlton
    EbuildSemiReservedName: version 20180207: line 41: uses semi-reserved variable name "B", likely to clash with future EAPIs
    EbuildSemiReservedName: version 20180207: line 42: uses semi-reserved variable name "R", likely to clash with future EAPIs
  
  dev-libs/teakra
    EbuildSemiReservedName: version 20220224: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  dev-python/js2py
    EbuildSemiReservedName: version 0.71_p20210918: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  dev-python/pyjsparser
    EbuildSemiReservedName: version 2.7.1_p20190421-r2: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  dev-ruby/mysql2
    EbuildSemiReservedName: version 0.5.3-r1: line 28: uses semi-reserved variable name "MDEPEND", likely to clash with future EAPIs
    EbuildSemiReservedName: version 0.5.3.20210920: line 34: uses semi-reserved variable name "MDEPEND", likely to clash with future EAPIs
    EbuildSemiReservedName: version 0.5.4: line 31: uses semi-reserved variable name "MDEPEND", likely to clash with future EAPIs
    EbuildSemiReservedName: version 0.5.5: line 31: uses semi-reserved variable name "MDEPEND", likely to clash with future EAPIs
  
  dev-scheme/guile-libyaml
    EbuildSemiReservedName: version 20211124: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  net-wireless/horst
    EbuildSemiReservedName: version 5.1: line 21: uses semi-reserved variable name "TDEPEND", likely to clash with future EAPIs
    EbuildSemiReservedName: version 9999: line 21: uses semi-reserved variable name "TDEPEND", likely to clash with future EAPIs
  
  sci-mathematics/btor2tools
    EbuildSemiReservedName: version 1.0.0_pre20220518-r1: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  sci-mathematics/boolector
    EbuildSemiReservedName: version 3.2.2_p20220110: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  sci-mathematics/metamath-databases
    EbuildSemiReservedName: version 20220303: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  sci-mathematics/smtinterpol
    EbuildSemiReservedName: version 2.5_p20211018: line 6: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  x11-misc/screenkey
    EbuildSemiReservedName: version 1.5_p20230109: line 19: uses semi-reserved variable name "H", likely to clash with future EAPIs
  
  x11-wm/xpra
    EbuildSemiReservedName: version 4.3.3: line 34: uses semi-reserved variable name "TDEPEND", likely to clash with future EAPIs
    EbuildSemiReservedName: version 4.3.4: line 34: uses semi-reserved variable name "TDEPEND", likely to clash with future EAPIs
    EbuildSemiReservedName: version 9999: line 33: uses semi-reserved variable name "TDEPEND", likely to clash with future EAPIs

@arthurzam arthurzam requested a review from thesamesam March 2, 2023 20:24
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.03 ⚠️

Comparison is base (fd7cf07) 80.18% compared to head (d1e4aef) 80.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   80.18%   80.15%   -0.03%     
==========================================
  Files          56       56              
  Lines        8401     8415      +14     
  Branches     1580     1903     +323     
==========================================
+ Hits         6736     6745       +9     
- Misses       1570     1571       +1     
- Partials       95       99       +4     
Impacted Files Coverage Δ
src/pkgcheck/checks/reserved.py 63.33% <70.00%> (-0.67%) ⬇️
src/pkgcheck/bash/__init__.py 82.85% <100.00%> (-0.48%) ⬇️
src/pkgcheck/pipeline.py 59.57% <0.00%> (ø)
src/pkgcheck/checks/network.py 39.77% <0.00%> (ø)
src/pkgcheck/checks/metadata_xml.py 62.74% <0.00%> (ø)
src/pkgcheck/results.py 86.63% <0.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/pkgcheck/checks/reserved.py Outdated Show resolved Hide resolved
Resolves: pkgcore#536
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@gentoo-bot gentoo-bot merged commit d1e4aef into pkgcore:master Mar 4, 2023
@arthurzam arthurzam deleted the semi-reserved branch March 7, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on semi-reserved variable names (single-letter uppercase variables and [A-z]DEPEND) in global scope
3 participants