Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfilesCheck: for unknown packages, mention last match removed #590

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

arthurzam
Copy link
Member

@arthurzam arthurzam requested a review from mgorny June 21, 2023 18:26
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 37.03% and project coverage change: -0.11 ⚠️

Comparison is base (9e55f88) 79.98% compared to head (afc779b) 79.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   79.98%   79.88%   -0.11%     
==========================================
  Files          57       57              
  Lines        8515     8536      +21     
  Branches     1935     1939       +4     
==========================================
+ Hits         6811     6819       +8     
- Misses       1604     1617      +13     
  Partials      100      100              
Impacted Files Coverage Δ
src/pkgcheck/checks/profiles.py 62.76% <37.03%> (-1.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arthurzam arthurzam force-pushed the profile-unknown-age branch from 5b94420 to 06be068 Compare June 21, 2023 19:32
@arthurzam arthurzam requested a review from mgorny June 22, 2023 16:01
@arthurzam arthurzam force-pushed the profile-unknown-age branch from 06be068 to fc5139a Compare June 22, 2023 19:00
pkgcore#588
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam force-pushed the profile-unknown-age branch from fc5139a to afc779b Compare June 24, 2023 05:49
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable with tests added. Thank you!

@gentoo-bot gentoo-bot merged commit afc779b into pkgcore:master Jun 24, 2023
@gentoo-bot gentoo-bot temporarily deployed to github-pages June 24, 2023 07:53 — with GitHub Actions Inactive
@arthurzam arthurzam deleted the profile-unknown-age branch June 24, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnknownProfilePackage: use blocker cache to mention "last match removed"
4 participants