Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerlCheck: check versioned virtual perl dependencies #597

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

arthurzam
Copy link
Member

@akhuettel @thesamesam So here it is. A
huge amount of matches across the repo. After some talks on IRC (#-perl) this is done as optional check, so folks need to enable PerlCheck for this result to appear.

I'm fine with any decision (merge or decline), so don't feel obligated 😄

Resolves: #593

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (2b9b8e7) 79.77% compared to head (59cfd9b) 79.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   79.77%   79.82%   +0.04%     
==========================================
  Files          58       58              
  Lines        8652     8673      +21     
  Branches     1966     1972       +6     
==========================================
+ Hits         6902     6923      +21     
  Misses       1648     1648              
  Partials      102      102              
Impacted Files Coverage Δ
src/pkgcheck/checks/perl.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arthurzam arthurzam requested a review from thesamesam July 3, 2023 19:55
@arthurzam
Copy link
Member Author

So we have:

[23:18:57] <@dilfridge> off by default is ok

So I guess we can continue with this and review before merge...

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Arthur!

src/pkgcheck/checks/perl.py Outdated Show resolved Hide resolved
src/pkgcheck/checks/perl.py Outdated Show resolved Hide resolved
Resolves: pkgcore#593
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam force-pushed the check-perl-virtual+ branch from ae58c45 to 59cfd9b Compare July 15, 2023 08:36
@gentoo-bot gentoo-bot merged commit 59cfd9b into pkgcore:master Jul 15, 2023
@gentoo-bot gentoo-bot temporarily deployed to github-pages July 15, 2023 08:53 — with GitHub Actions Inactive
@arthurzam arthurzam deleted the check-perl-virtual+ branch August 3, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request, new check: Perl virtual dependencies
3 participants