author/CD fix, fixes for reliance on category_dirs and that being fundamentally broken in pkgcore
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Harring <ferringb@gmail.com>
Signed-off-by: Brian Harring <ferringb@gmail.com>
This is beyond corner case, but if someone has a non directory in place of where a category is supposed to be, pkgcore and portage will silently suppress this. Pkgcore will be modified to emit a warning for this, but in the meantime, it's a cheap check, thus add it. Signed-off-by: Brian Harring <ferringb@gmail.com>
pkgcore's `category_dirs` is a fossil that shouldn't be relied upon. My recollection is this property was from before `profiles/categories` existed, but it's just a listdir() intersection against known directories. PMS mandates categories be in `profiles/categories`, thus that functionality breaks compatibility. It will be removed from pkgcore in future semver breaks for that reason. Signed-off-by: Brian Harring <ferringb@gmail.com>
arthurzam
approved these changes
Jan 24, 2024
gentoo-bot
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Yeah, I figured it was the pyproject.toml transfer. Shit happens, even if I grumble mildly during it... so no worries ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough summary:
category_dirsfrom EbuildRepo. See https://github.com/pkgcore/pkgcore/blob/677649351c171685d332b9d9e500da31baf33a74/src/pkgcore/ebuild/repository.py#L527 ; if no categories were inherited or declared, pkgcore violates PMS via falling back to a listdir of the repo root (see https://github.com/pkgcore/pkgcore/blob/677649351c171685d332b9d9e500da31baf33a74/src/pkgcore/ebuild/repository.py#L506 ). As said, this violates PMS. Remove reliance on it in pkgcheck in light of that.There probably should be an explicit check added for if a standalone repository doesn't declare any categories, but that would be a seperate PR.