Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix linkage to downstream dependences #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferringb
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0751928) 64.99% compared to head (863e25f) 64.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   64.99%   64.99%           
=======================================
  Files          57       57           
  Lines        6133     6133           
  Branches     1261     1261           
=======================================
  Hits         3986     3986           
+ Misses       1912     1911    -1     
- Partials      235      236    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ferringb ferringb changed the title docs: Update intersphinx location for py3k. docs: fix linkage to downstream dependences Jan 26, 2024
@ferringb
Copy link
Contributor Author

I've updated the PR to use https://pypi.org/project/seed-intersphinx-mapping/ so it automatically tries any pyproject.toml dependencies that have project.url defined. This addresses the DRY aspect.

@arthurzam
Copy link
Member

I've updated the PR to use https://pypi.org/project/seed-intersphinx-mapping/ so it automatically tries any pyproject.toml dependencies that have project.url defined. This addresses the DRY aspect.

I'm a little bit against adding seed_intersphinx_mapping, since it seems like a hell to include in gentoo packages (it uses weird build system - WTF is whey, it can't be simpler than flit_core) (has more dependencies in there).
doc building is a must for pkgcheck & pkgdev on Gentoo, so can't just hide it.
I also think those lines repeating itself aren't the end of the world, or end of the week, so not so bad in my opinion.

Signed-off-by: Brian Harring <ferringb@gmail.com>
@ferringb
Copy link
Contributor Author

I've updated the PR to use https://pypi.org/project/seed-intersphinx-mapping/ so it automatically tries any pyproject.toml dependencies that have project.url defined. This addresses the DRY aspect.

I'm a little bit against adding seed_intersphinx_mapping, since it seems like a hell to include in gentoo packages (it uses weird build system - WTF is whey, it can't be simpler than flit_core) (has more dependencies in there). doc building is a must for pkgcheck & pkgdev on Gentoo, so can't just hide it. I also think those lines repeating itself aren't the end of the world, or end of the week, so not so bad in my opinion.

What's the alternative here? I grok that sounds a bit like "pound sand" (an american phrase that is basically "fuck off"), but that's not my intent.

Trust me, I rewrote a shitton of tooling I didn't like (typically having to fork), but I also recognize at this point it didn't serve the end goal.

As to 'hell', no argument. My counter argument pretty much comes down to which battles we wish to fight, in terms of where we apply our energy towards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants