MVP #2

dominykas · 2021-10-08T15:50:40Z

Closes #1

See individual commit messages for some notes
This was working for me when testing with dominykas/pkgjs-action as the action/workflow source
- We'll need to follow up with automated detection, because it will be hard to test forks otherwise
node_modules is checked in so that github actions can use it directly
There's obviously a lot of features needed here, but that's not the goal for the initial PR
Usage example is in the PR: https://github.com/pkgjs/action/pull/2/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR7-R9 - but that of course does not replace good documenation, which is still pending...
Not going to tag a version until we're ready

- The primary purpose behind the package.json is to enable self testing as the workflow will rely on the `package.json` in the root folder - Setting `private: true` as this is not intended for publishing into the registry

- Adding node_modules to source control so that the modules are available when running as a Github Action - Adding the shrinkwrap so that people can verify integrity of `node_modules` via `npm ci`

- Source: https://raw.githubusercontent.com/nodejs/Release/master/schedule.json - Adding a cached version to the source control here to save some Actions seconds

- Running tests without any test framework because they're simple enough and I don't want to bloat the `node_modules` in the action folder

mcollina

lgtm

dominykas added 4 commits October 8, 2021 18:35

ci: initial boilerplate

d15d389

- The primary purpose behind the package.json is to enable self testing as the workflow will rely on the `package.json` in the root folder - Setting `private: true` as this is not intended for publishing into the registry

chore: install semver

db97ce8

- Adding node_modules to source control so that the modules are available when running as a Github Action - Adding the shrinkwrap so that people can verify integrity of `node_modules` via `npm ci`

feat: add schedule.json

1365a21

- Source: https://raw.githubusercontent.com/nodejs/Release/master/schedule.json - Adding a cached version to the source control here to save some Actions seconds

feat: basic node-test workflow

66bf678

- Running tests without any test framework because they're simple enough and I don't want to bloat the `node_modules` in the action folder

dominykas changed the title ~~ci: initial boilerplate~~ MVP Oct 8, 2021

dominykas mentioned this pull request Oct 8, 2021

MVP: reusable workflow #1

Closed

docs: add usage details

429190b

dominykas mentioned this pull request Oct 11, 2021

Support different OS, architecture options in the test matrix #4

Closed

mcollina approved these changes Oct 22, 2021

View reviewed changes

dominykas merged commit 7499514 into pkgjs:main Oct 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MVP #2

MVP #2

dominykas commented Oct 8, 2021 •

edited

Loading

mcollina left a comment

MVP #2

MVP #2

Conversation

dominykas commented Oct 8, 2021 • edited Loading

mcollina left a comment

Choose a reason for hiding this comment

dominykas commented Oct 8, 2021 •

edited

Loading