Skip to content

Conversation

bcoe
Copy link
Collaborator

@bcoe bcoe commented Apr 10, 2022

Pulling in suggestions from @VoltrexMaster in nodejs/node#42675

@shadowspawn
Copy link
Collaborator

shadowspawn commented Apr 10, 2022

This looks like a subset of the ones raised/applied upstream. Not sure if you are planning to maintain in parallel, or copy-paste down? (i.e. is it worth me doing more PR here or will a future sync catch up?)

@bcoe
Copy link
Collaborator Author

bcoe commented Apr 10, 2022

This looks like a subset of the ones raised/applied upstream. Not sure if you are planning to maintain in parallel, or copy-paste down?

I'm trying to keep things so that we can just copy and paste the code from here into the Node.js PR. So let's make changes in this repo, and I'll periodically sync the upstream PR.

@bcoe bcoe merged commit ba4815e into main Apr 10, 2022
@bcoe bcoe deleted the nits-from-review branch April 10, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants