Switch Travis to GH Actions #61
Conversation
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [ 15, 14, 12, 10 ] |
There was a problem hiding this comment.
“engines” isn’t set in package.json. Is this the range it should be set to?
There was a problem hiding this comment.
I think I'd rather set the support policy, but in general the engines field is not really expressive enough and is probably outside of scope here anyways.
There was a problem hiding this comment.
If the engines field is omitted, its API is "whatever engines the .0.0 works on", so if we don't want to accidentally support v9 or v8 or something, we'd better provide it :-)
There was a problem hiding this comment.
I did create #62 yesterday.
It's not like someone will come and complain that this doesn't work in 8. And if they do - I'm sure we can deal with it.
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: |
There was a problem hiding this comment.
i have an action that encapsulates the last three steps, if we’re interested: https://github.com/ljharb/object.assign/blob/8f4cda901aff48de61267c75806d7f05bc2ca2c2/.github/workflows/node-4%2B.yml#L27
There was a problem hiding this comment.
Your approach does have the benefit of making it much clearer where the matrix applies, alright, but I'm not confident about what I do or don't like about various different GH action approaches, so I'm not sure I'm ready to make this call just yet.
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 |
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.