Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json #65

Merged
merged 4 commits into from
Dec 19, 2020
Merged

Update package.json #65

merged 4 commits into from
Dec 19, 2020

Conversation

rodion-arr
Copy link
Member

  • Adds support info
  • Adds engines field

Closes #62

@rodion-arr
Update package.json
e72e354 
- Add support info
- Add `engines` field
@rodion-arr
Copy link
Member Author

I'm not fully confident in engines field, so if I've put not correct value, will be happy to update.

Based on CI - we run on LTS + v15. But I'm not sure how engine field like "^15 || ^14 || ^13 || ^12 || ^10" will behave in case this package will be installed on non-LTS, so I just put v10+.

@ljharb
Copy link
Member

ljharb commented Dec 13, 2020

It should behave fine. If we don’t want to support node 11 (or 13, which also isn’t lts) we need the ^ form.

@rodion-arr
Copy link
Member Author

Thanks, updated

@dominykas
Copy link
Member

Thanks for this PR!

I'm not sure we should "support" v15 - we should use lts_active policy instead and remove the v15 from the engines. Testing in v15 is just to get a heads up before the next LTS.

dominykas
dominykas reviewed Dec 14, 2020
View reviewed changes
package-support.json Outdated Show resolved Hide resolved
@rodion-arr @dominykas
Update package-support.json
e9ad031 
Co-authored-by: Dominykas Blyžė <hello@dominykas.com>
@dominykas dominykas merged commit 27c9266 into pkgjs:master Dec 19, 2020
@dominykas
Copy link
Member

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rodion-arr rodion-arr deleted the add-support branch January 3, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@dominykas dominykas dominykas approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support info
4 participants
@rodion-arr @ljharb @dominykas @BethGriggs