upload-artifact@v4 doesn't like percents

pkgxdev · Dec 15, 2023 · 4698cf2 · jhheider · Dec 15, 2023 · 4698cf2
1 parent 4293cd2
commit 4698cf2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/download-build-artifact/action.yml b/download-build-artifact/action.yml
@@ -63,7 +63,7 @@ runs:
       id: prep
       shell: bash
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       id: download
       with:
         name: ${{ steps.prep.outputs.artifact-name }}

diff --git a/lib/actions/platform-key.ts b/lib/actions/platform-key.ts
@@ -18,4 +18,4 @@ if (pkg === true) pkg = undefined
 
 const config = await get_config(pkg as string | undefined)
 
-console.log(`${encodeURIComponent(utils.pkg.str(config.pkg))}+${platform}`)
+console.log(`${utils.pkg.str(config.pkg).replace('/', '_')}+${platform}`)
diff --git a/upload-build-artifact/action.yml b/upload-build-artifact/action.yml
@@ -40,8 +40,9 @@ runs:
       id: tar
       shell: bash
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         path: ${{ steps.tar.outputs.path }}
         name: ${{ steps.tar.outputs.name }}
         if-no-files-found: error
+        retention-days: 1
Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,4 +18,4 @@ if (pkg === true) pkg = undefined

		const config = await get_config(pkg as string \| undefined)

		console.log(`${encodeURIComponent(utils.pkg.str(config.pkg))}+${platform}`)
		console.log(`${utils.pkg.str(config.pkg).replace('/', '_')}+${platform}`)
This comment has been minimized. Sign in to view Copy link jhheider Dec 15, 2023 Contributor `717f610`