Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working-directory in build scripts doesn't like moustaches #117

Closed
jhheider opened this issue May 14, 2023 · 3 comments
Closed

working-directory in build scripts doesn't like moustaches #117

jhheider opened this issue May 14, 2023 · 3 comments

Comments

@jhheider
Copy link
Contributor 

    - run: |
        mv aws/* .
        rmdir aws
        ln -s . aws
      working-directory: "{{prefix}}/include"

produces:

mv aws/* .
rmdir aws
ln -s . aws

instead of:

OLDWD="$PWD"
mkdir -p "/Users/jacob/.tea/foo.bar/v1.2.3/include"
cd "/Users/jacob/.tea/foo.bar/v1.2.3/include"
mv aws/* .
rmdir aws
ln -s . aws
cd "$OLDWD"
unset OLDWD
jhheider added a commit to JrGoodle/pantry that referenced this issue May 14, 2023
@jhheider
appears moustaches don't work here
b7b6014 
pkgxdev/brewkit#117
@mxcl
Copy link
Member

mxcl commented May 15, 2023

something suss there, even if it didn't tokenize (which it should, I'm looking at the code) the only way it wouldn't add the top and bottom boilerplate is if the yaml didn't have the right shape.

Got an example of it failing?

@jhheider
Copy link
Contributor Author

That's the result of local testing. I was trying to use it when working out pkgxdev/pantry#1828

@jhheider
Copy link
Contributor Author

I agree that it looks like it should work, from the code.

jhheider added a commit to pkgxdev/pantry that referenced this issue May 20, 2023
@JrGoodle @jhheider
+aws-sdk-cpp (#1828)
9378f80 
* [wip] +aws-sdk-cpp

* add git for now

* use upcoming `git` distributable

this works with the upcoming brewkit 0.31.0

* appears moustaches don't work here

pkgxdev/brewkit#117

* add missing deps

---------

Co-authored-by: Jacob Heider <jacob@tea.xyz>
mxcl added a commit that referenced this issue Dec 12, 2023
@mxcl
brewkit v1
97fb9dd 
* rewrite in mostly TypeScript
* `pkg` -> `bk` to avoid confusion with `pkgx`
* proper actions
* pkgx pantry specific infra moved to pantry
* irrelevant commands removed to be put into `mash`
* changes are now fully tested in CI without needing pkgx pantry packages
* Fixes #173
* builds occur to separate prefix to aid relocatability testing (Fixes #166)
* Refs #160
* Fixes #158
* Fixes #157
* Fixes #129
* Fixes #117 (though I didn’t explicitly fix this we have a fixture showing this working now)
mxcl added a commit that referenced this issue Dec 12, 2023
@mxcl
brewkit v1
9628735 
* rewrite in mostly TypeScript
* `pkg` -> `bk` to avoid confusion with `pkgx`
* proper actions
* pkgx pantry specific infra moved to pantry
* irrelevant commands removed to be put into `mash`
* changes are now fully tested in CI without needing pkgx pantry packages
* Fixes #173
* builds occur to separate prefix to aid relocatability testing (Fixes #166)
* Refs #160
* Fixes #158
* Fixes #157
* Fixes #129
* Fixes #117 (though I didn’t explicitly fix this we have a fixture showing this working now)
* Feat: initializes a git repo in the sources so you can easily get a diff for your build script
@mxcl mxcl closed this as completed in e7251b9 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mxcl @jhheider