Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script array lines starting with { don't work with ${ #141

Closed
jhheider opened this issue Jun 20, 2023 · 3 comments
Closed

script array lines starting with { don't work with ${ #141

jhheider opened this issue Jun 20, 2023 · 3 comments

Comments

@jhheider
Copy link
Contributor

    - run: ${{prefix}}/venv/bin/pip install paramiko #FIXME should we pin a version?
/Users/jacob/tea/pantry/builds/ansible.com-2.15.1+darwin/xyz.tea.build.sh: line 44: $/Users/jacob/.tea/ansible.com/v2.15.1/venv/bin/pip: No such file or directory
    - run: {{prefix}}/venv/bin/pip install paramiko #FIXME should we pin a version?
error: Uncaught Error: pantry entry invalid. please report this bug!
...
    - run: ./bin/pip install paramiko #FIXME should we pin a version?
      working-directory: ${{prefix}}/venv

^^^^ this works fine

@mxcl
Copy link
Member

mxcl commented Jun 20, 2023

is it valid yaml? VSCode certainly doesn't think so. I think if you start the line with { you have to quote it, which is why we allow ${{moustaches}} at the line beginnings.

@jhheider
Copy link
Contributor Author

jhheider commented Jun 20, 2023

I didn't try quoting it, but we don't appear to allow '$' for this key specifically (first example).

@mxcl
Copy link
Member

mxcl commented Jun 20, 2023

aah well, certainly we should allow that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants