Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift doesn't like extended UTF-8 in TMPDIR #262

Closed
jhheider opened this issue Jan 10, 2024 · 9 comments
Closed

swift doesn't like extended UTF-8 in TMPDIR #262

jhheider opened this issue Jan 10, 2024 · 9 comments

Comments

@jhheider
Copy link
Contributor

Build issues in SwiftFormat and xcbeautify; fix below:

          ok, this fixes it:
    - export TMPDIR=$(mktemp -d)

so, it's not liking, apparently, the extended unicode characters in the TMPDIR envvar. slightly gross. but an easy fix.

Originally posted by @jhheider in pkgxdev/pantry#4781 (comment)

@mxcl
Copy link
Member

mxcl commented Jan 10, 2024

I should probs should just drop the unicode characters in general.

@jhheider
Copy link
Contributor Author

Colons. They're valid on normal filesystems, but rarely used in URLs (and why would we ever include one in a package name?).

@mxcl
Copy link
Member

mxcl commented Jan 10, 2024

we don't add a colon deliberately. I didn't see an example of the failing TMPDIR in the attached link. Can you provide?

@jhheider
Copy link
Contributor Author

you can get it locally easily enough (just comment out that one-line patch). here's an example in GHA: https://github.com/pkgxdev/pantry/actions/runs/7455318137/job/20284215852

@mxcl
Copy link
Member

mxcl commented Jan 10, 2024

TMPDIR=/Users/builder/actions-runner/_work/pantry/pantry/homes/tuist.io∕xcbeautify-1.4.0/tmp

there’s no colon in that. I'm confused about the reference to colons I guess.

@jhheider
Copy link
Contributor Author

sorry; was recommending regular old ASCII colons instead of fancy UTF-8 .

@mxcl
Copy link
Member

mxcl commented Jan 10, 2024

oic. We should use a standard character. I may just switch to actual folders it's not that onerous.

@jhheider
Copy link
Contributor Author

yeah, the only issue with folders is variable number of path elements, which the UTF-8 slash nicely bypasses. not impossible to work with, but something that's been mildly annoying in the past.

@mxcl
Copy link
Member

mxcl commented Jan 11, 2024

I note that you have hardcoded +brewing in the pantry now. I was going to change the + to something that doesn't break regexes.

The examples that hardcode +brewing have no comments so I don't understand what is happening or why.

Please open tickets on brewkit, I cannot make brewkit more robust if all the fixes are one-off hacks in the pantry. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants