Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform: #270

Closed
jhheider opened this issue Jan 12, 2024 · 4 comments · Fixed by #271
Closed

transform: #270

jhheider opened this issue Jan 12, 2024 · 4 comments · Fixed by #271

Comments

@jhheider
Copy link
Contributor

@mxcl: the transform: key seems like it might be behaving oddly. from the build logs of pkgxdev/pantry#4830:

{ v: "jdk-17.0.1+7", rv: "17.0.1.7" }
{ v: "jdk-17.0.1+8", rv: "17.0.1.8" }
{ v: "jdk-17.0.1+9", rv: "17.0.1.9" }
{ v: "jdk-17.0.1+10", rv: "17.0.1.10" }
{ v: "jdk-17-ga", rv: "17-ga" }
{ v: "jdk-17.0.1+11", rv: "17.0.1.11" }
{ v: "jdk-17.0.1+12", rv: "17.0.1.12" }
{ v: "jdk-17.0.2+1", rv: "17.0.2.1" }
{ v: "jdk-17.0.2+2", rv: "17.0.2.2" }
{ v: "jdk-17.0.1-ga", rv: "17.0.1-ga" }
{ v: "jdk-17.0.2+3", rv: "17.0.2.3" }
{ v: "jdk-17.0.2+4", rv: "17.0.2.4" }
{ v: "jdk-17.0.2+5", rv: "17.0.2.5" }
{ v: "jdk-17.0.2+6", rv: "17.0.2.6" }
{ v: "jdk-17.0.2+7", rv: "17.0.2.7" }

but it seems to be selecting the first one 17.0.1.7 for ^17, rather than 17.0.10.6.

as an aside, should strip: and transform: be mutually exclusive? it looks like they're handled transform > strip, which surprised me, but there's no real reason it should have. as long as version.tag is still preserved, all should be fine. 🤞

@jhheider
Copy link
Contributor Author

looks like the error is here:

const read = cmd.stdout.getReader().read().then(x => x.value)

that only seems returns the first line. trying some loop finagling to get the rest of the output.

@jhheider
Copy link
Contributor Author

actually, it's much easier. just grab cmd.output().stdout.

@mxcl
Copy link
Member

mxcl commented Jan 13, 2024

as an aside, should strip: and transform: be mutually exclusive? it looks like they're handled transform > strip, which surprised me

I wasn't sure what order strip etc. should work in if coupled with transform. So elected to make them exclusive. I agree this is hidden knowledge and I hate that.

@mxcl mxcl closed this as completed in #271 Jan 13, 2024
mxcl pushed a commit that referenced this issue Jan 13, 2024
@jhheider
Copy link
Contributor Author

i know vscode's editor knows which keys are valid for gha action schema. it'd be nice if there we could publish a schema for package.yml, though the flux is still high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants