Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ignoring github pre-releases optional #327

Open
jhheider opened this issue Apr 12, 2024 · 3 comments
Open

make ignoring github pre-releases optional #327

jhheider opened this issue Apr 12, 2024 · 3 comments

Comments

@jhheider
Copy link
Contributor

See: https://github.com/foundry-rs/foundry/releases

jhheider added a commit to pkgxdev/pantry that referenced this issue Apr 12, 2024
jhheider added a commit to pkgxdev/pantry that referenced this issue Apr 12, 2024
* update(forge)

would benefit from pkgxdev/brewkit#327

* fix test
@rustdevbtw
Copy link
Contributor

Or perhaps (for less breaking), make including pre-releases optional?

Something like this:

versions:
    github: org/repo/releases
    strip: /v/
    prerelease: true # this

Or, maybe an additional /pre-releases option?
Like:

versions:
    - github: org/repo/pre-releases
      strip: /v/
    # If they release any proper (stable) version, it'd match that as well.
    - github: org/repo/releases
      strip: /v/

@jhheider
Copy link
Contributor Author

Exactly. include-prereleases: bool? was what I was thinking.

@mxcl
Copy link
Member

mxcl commented Sep 7, 2024

Really we should build them and then have pkgx ignore them by default. If they don’t build then we discard that release because we don't care much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants