release without pre-release #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a pre-release before “un-pre-releasing” it is not proper. The pre-release flag is mean to convey eg.
alpha,beta.The ideal flow IMO is we create a draft release and then github actions takes over.
However in their infinite wisdom GitHub decided that creating draft releases cannot trigger workflows 😒
So instead we convert
cd.ymlto a worfklow dispatch and remove the pre-release step.Having written this I actually disagree with myself, pre-release will do. The only advantage of what I wrote here is that we correctly calculate the previous tag so the generated release notes are correct rather than it always comparing with the
v0tag.